[
https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377844#comment-16377844
]
Kenneth Knowles edited comment on BEAM-3749 at 2/27/18 12:39 AM:
-----------------------------------------------------------------
I don't think the description is quite right - BeamSql doesn't use the
{{DefaultTrigger}}, does it? I think it uses whatever trigger is set up, which
could be anything.
What about this?
{code}
PCollectionTuple inputTables = ...;
input.apply(Window.triggering(trigger).discardingFiredPanes()) // or
accumulatingFiredPanes
.apply(BeamSql.query("..."));
{code}
This should allow the CLI to apply the trigger and accumulation mode outside of
the SQL transform. This will use the continuation trigger the right way
everywhere.
was (Author: kenn):
What about this?
{code}
PCollectionTuple inputTables = ...;
input.apply(Window.triggering(trigger).discardingFiredPanes()) // or
accumulatingFiredPanes
.apply(BeamSql.query("..."));
{code}
This should allow the CLI to apply the trigger and accumulation mode outside of
the SQL transform. This will use the continuation trigger the right way
everywhere.
> support customized trigger/accumulationMode in BeamSql
> ------------------------------------------------------
>
> Key: BEAM-3749
> URL: https://issues.apache.org/jira/browse/BEAM-3749
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Major
> Fix For: 2.4.0
>
>
> Currently BeamSql use {{DefaultTrigger}} for aggregation operations.
> By adding two options {{withTrigger(Trigger)}} and
> {{withAccumulationMode(AccumulationMode)}}, developers can specify their own
> aggregation strategies with BeamSql.
> [~xumingming] [~kedin] [~kenn] for any comments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
