[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377862#comment-16377862 ]
Xu Mingmin edited comment on BEAM-3749 at 2/27/18 12:55 AM: ------------------------------------------------------------ {{Window.triggering(trigger).discardingFiredPanes()}} is not valid so far, is it a work-in-progress feature? It's always {{Window.into(...).triggering(...)...}}. Currently TUMBLE/HOP/SESSION don't take Trigger parameter and IMO it's {{DefaultTrigger}} as no Trigger is set explicitly, +[~kedin] for comments. was (Author: mingmxu): {{Window.triggering(trigger).discardingFiredPanes()}} is not valid so far, is it a work-in-progress feature? It's always {{Window.into(...).triggering(...)...}}. Currently TUMBLE/HOP/SESSION doesn't take Trigger parameter and IMO it's {{DefaultTrigger}} as no Trigger is set explicitly, +[~kedin] for comments. > support customized trigger/accumulationMode in BeamSql > ------------------------------------------------------ > > Key: BEAM-3749 > URL: https://issues.apache.org/jira/browse/BEAM-3749 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Fix For: 2.4.0 > > > Currently BeamSql use {{DefaultTrigger}} for aggregation operations. > By adding two options {{withTrigger(Trigger)}} and > {{withAccumulationMode(AccumulationMode)}}, developers can specify their own > aggregation strategies with BeamSql. > [~xumingming] [~kedin] [~kenn] for any comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)