[ https://issues.apache.org/jira/browse/BEAM-3776?focusedWorklogId=80100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80100 ]
ASF GitHub Bot logged work on BEAM-3776: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Mar/18 22:32 Start Date: 13/Mar/18 22:32 Worklog Time Spent: 10m Work Description: scwhittle commented on a change in pull request #4793: [BEAM-3776] Fix issue with merging late windows where a watermark hold could be added behind the input watermark. URL: https://github.com/apache/beam/pull/4793#discussion_r174305824 ########## File path: runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnRunnerTest.java ########## @@ -873,6 +907,288 @@ public void testWatermarkHoldAndLateData() throws Exception { tester.assertHasOnlyGlobalAndFinishedSetsFor(); } + @Test + public void testMergingWatermarkHoldAndLateDataSpecific() throws Exception { Review comment: Would you prefer: - a test helper function taking configuration objects with separate tests for each configuration - remove most of these and just keep a complicated one - making a lot of separate tests but removing configuration object and just duplicating test setup These were written at the same time as I detected this issue but are unrelated. They seem like useful additional coverage but I could also put them into a separate change if you'd prefer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 80100) Time Spent: 2h (was: 1h 50m) > StateMerging.mergeWatermarks sets a late watermark hold for late merging > windows that depend only on the window > --------------------------------------------------------------------------------------------------------------- > > Key: BEAM-3776 > URL: https://issues.apache.org/jira/browse/BEAM-3776 > Project: Beam > Issue Type: Bug > Components: runner-core > Affects Versions: 2.1.0, 2.2.0, 2.3.0 > Reporter: Sam Whittle > Assignee: Sam Whittle > Priority: Critical > Time Spent: 2h > Remaining Estimate: 0h > > WatermarkHold.addElementHold and WatermarkHold.addGarbageCollectionHold take > to not add holds that would be before the input watermark. > However WatermarkHold.onMerge calls StateMerging.mergeWatermarks which if the > window depends only on window, sets a hold for the end of the window > regardless of the input watermark. > Thus if you have a WindowingStrategy such as: > WindowingStrategy.of(Sessions.withGapDuration(gapDuration)) > .withMode(AccumulationMode.DISCARDING_FIRED_PANES) > .withTrigger( > Repeatedly.forever( > AfterWatermark.pastEndOfWindow() > .withLateFirings(AfterPane.elementCountAtLeast(10)))) > .withAllowedLateness(allowedLateness)) > and you merge windows that are late, you might end up holding the watermark > until the allowedLateness has passed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)