[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=86703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86703
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 18:59
Start Date: 02/Apr/18 18:59
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#4990: [BEAM-3981] Futurize and fix python 2 compatibility for coders subpackage
URL: https://github.com/apache/beam/pull/4990#discussion_r178620576
##########
File path: sdks/python/apache_beam/coders/stream.pyx
##########
@@ -39,7 +39,7 @@ cdef class OutputStream(object):
if self.data:
libc.stdlib.free(self.data)
- cpdef write(self, bytes b, bint nested=False):
+ cpdef write(self, b, bint nested=False):
Review comment:
The bytes type has been removed from this module for now, since a mismatch
between the cython bytes type and future bytes type results in a TypeError:
expected bytes, got newbytes.
I have tried replacing bytes with a memory view as explained
[here](http://cython.readthedocs.io/en/latest/src/tutorial/strings.html#accepting-strings-from-python-code),
but this resulted in a packaging error.
Any help on this would be appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 86703)
Time Spent: 20m (was: 10m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
