[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=86724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86724
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 19:57
Start Date: 02/Apr/18 19:57
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#4990: [BEAM-3981] Futurize and fix python 2 compatibility for coders subpackage
URL: https://github.com/apache/beam/pull/4990#discussion_r178633438
##########
File path: sdks/python/apache_beam/coders/proto2_coder_test_messages_pb2.py
##########
@@ -17,16 +17,15 @@
# Generated by the protocol buffer compiler. DO NOT EDIT!
# source: sdks/java/core/src/main/proto/proto2_coder_test_messages.proto
-
-import sys
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
Review comment:
<!--new_thread; commit:8f4ed891ad8e0a0b3c7da031a7618c00545b64e5;
resolved:0-->
Should we revert the changes in this generated file?
Also, which of these is really necessary? Do we use division and print in
this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 86724)
Time Spent: 1h 20m (was: 1h 10m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
