[ https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=86735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86735 ]
ASF GitHub Bot logged work on BEAM-3981: ---------------------------------------- Author: ASF GitHub Bot Created on: 02/Apr/18 19:57 Start Date: 02/Apr/18 19:57 Worklog Time Spent: 10m Work Description: charlesccychen commented on a change in pull request #4990: [BEAM-3981] Futurize and fix python 2 compatibility for coders subpackage URL: https://github.com/apache/beam/pull/4990#discussion_r178633471 ########## File path: sdks/python/apache_beam/coders/coder_impl.py ########## @@ -27,10 +27,14 @@ For internal use only; no backwards-compatibility guarantees. """ from __future__ import absolute_import +from __future__ import division +from __future__ import print_function -from types import NoneType - -import six +from builtins import chr +from builtins import int Review comment: <!--new_thread; commit:05e95b6995f0b88a53930c30459c8d81e6692219; resolved:0--> For my edification, is this the recommended way of using these types / methods in python 3? Are they no longer in the global namespace? It seems a bit verbose to have to import `object` like this in every file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 86735) Time Spent: 2h 50m (was: 2h 40m) > Futurize and fix python 2 compatibility for coders package > ---------------------------------------------------------- > > Key: BEAM-3981 > URL: https://issues.apache.org/jira/browse/BEAM-3981 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Ahmet Altay > Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > Run automatic conversion with futurize tool on coders subpackage and fix > python 2 compatibility. This prepares the subpackage for python 3 support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)