[ https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=86731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86731 ]
ASF GitHub Bot logged work on BEAM-3981: ---------------------------------------- Author: ASF GitHub Bot Created on: 02/Apr/18 19:57 Start Date: 02/Apr/18 19:57 Worklog Time Spent: 10m Work Description: charlesccychen commented on a change in pull request #4990: [BEAM-3981] Futurize and fix python 2 compatibility for coders subpackage URL: https://github.com/apache/beam/pull/4990#discussion_r178633459 ########## File path: sdks/python/apache_beam/coders/coders.py ########## @@ -33,6 +36,11 @@ from apache_beam.portability.api import beam_runner_api_pb2 from apache_beam.utils import proto_utils +try: + import cPickle as pickle +except ImportError: + import pickle Review comment: <!--new_thread; commit:21005b886b32241736b829e18f0aa386bbfbc13f; resolved:0--> Please add comment that this is for Py2/3 compatibility, since in Python 3, cPickle was renamed pickle. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 86731) Time Spent: 2h 20m (was: 2h 10m) > Futurize and fix python 2 compatibility for coders package > ---------------------------------------------------------- > > Key: BEAM-3981 > URL: https://issues.apache.org/jira/browse/BEAM-3981 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Ahmet Altay > Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Run automatic conversion with futurize tool on coders subpackage and fix > python 2 compatibility. This prepares the subpackage for python 3 support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)