[ https://issues.apache.org/jira/browse/BEAM-3994?focusedWorklogId=87256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87256 ]
ASF GitHub Bot logged work on BEAM-3994: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Apr/18 20:22 Start Date: 03/Apr/18 20:22 Worklog Time Spent: 10m Work Description: bsidhom opened a new pull request #5008: [BEAM-3994] Use typed client pool sinks and sources URL: https://github.com/apache/beam/pull/5008 Introduce a new `ControlClientPool` that knows about both control client sources and sinks. ------------------------ Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 87256) Time Spent: 10m Remaining Estimate: 0h > Use typed sinks and sources for FnApiControlClientPoolService > ------------------------------------------------------------- > > Key: BEAM-3994 > URL: https://issues.apache.org/jira/browse/BEAM-3994 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Ben Sidhom > Assignee: Ben Sidhom > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > We operate with blocking queues directly when managing control clients with > the FnApiControlClientPoolService. This makes interactions with the client > pool difficult to understand. We should instead make client sources and sinks > explicit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)