[
https://issues.apache.org/jira/browse/BEAM-3994?focusedWorklogId=89187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89187
]
ASF GitHub Bot logged work on BEAM-3994:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/18 23:22
Start Date: 09/Apr/18 23:22
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5008:
[BEAM-3994] Use typed client pool sinks and sources
URL: https://github.com/apache/beam/pull/5008#discussion_r180258427
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolService.java
##########
@@ -34,13 +34,14 @@
implements FnService {
private static final Logger LOGGER =
LoggerFactory.getLogger(FnApiControlClientPoolService.class);
- private final BlockingQueue<FnApiControlClient> clientPool;
+ private final ThrowingConsumer<? super FnApiControlClient> clientPool;
private final Collection<FnApiControlClient> vendedClients = new
CopyOnWriteArrayList<>();
private final HeaderAccessor headerAccessor;
private AtomicBoolean closed = new AtomicBoolean();
private FnApiControlClientPoolService(
- BlockingQueue<FnApiControlClient> clientPool, HeaderAccessor
headerAccessor) {
+ ThrowingConsumer<? super FnApiControlClient> clientPool,
Review comment:
`clientConsumer`?
We don't know if it's a pool or what.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 89187)
Time Spent: 1h 40m (was: 1.5h)
> Use typed sinks and sources for FnApiControlClientPoolService
> -------------------------------------------------------------
>
> Key: BEAM-3994
> URL: https://issues.apache.org/jira/browse/BEAM-3994
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We operate with blocking queues directly when managing control clients with
> the FnApiControlClientPoolService. This makes interactions with the client
> pool difficult to understand. We should instead make client sources and sinks
> explicit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
