[
https://issues.apache.org/jira/browse/BEAM-3355?focusedWorklogId=88509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88509
]
ASF GitHub Bot logged work on BEAM-3355:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/18 17:25
Start Date: 06/Apr/18 17:25
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4311:
[BEAM-3355] Diagnostic interfaces
URL: https://github.com/apache/beam/pull/4311#discussion_r179816955
##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -37,12 +35,13 @@ import (
// TODO(herohde) 2/8/2017: for now, assume we stage a full binary (not a
plugin).
// Main is the main entrypoint for the Go harness. It runs at "runtime" -- not
-// "pipeline-construction time" -- on each worker. It is a Fn API client and
+// "pipeline-construction time" -- on each worker. It is a FnAPI client and
// ultimately responsible for correctly executing user code.
func Main(ctx context.Context, loggingEndpoint, controlEndpoint string) error {
- setupRemoteLogging(ctx, loggingEndpoint)
- setupDiagnosticRecording()
+ hooks.DeserializeHooks()
+ hooks.RunInitHooks(ctx)
+ setupRemoteLogging(ctx, loggingEndpoint)
recordHeader()
Review comment:
Question: is session not being converted to a hook at this time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 88509)
Time Spent: 6h 20m (was: 6h 10m)
> Make Go SDK runtime harness hooks pluggable
> -------------------------------------------
>
> Key: BEAM-3355
> URL: https://issues.apache.org/jira/browse/BEAM-3355
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Bill Neubauer
> Priority: Minor
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> We currently hardcode cpu profiling and session recording in the harness. We
> should make it pluggable instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
