[ 
https://issues.apache.org/jira/browse/BEAM-3355?focusedWorklogId=88513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88513
 ]

ASF GitHub Bot logged work on BEAM-3355:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Apr/18 17:25
            Start Date: 06/Apr/18 17:25
    Worklog Time Spent: 10m 
      Work Description: herohde commented on a change in pull request #4311: 
[BEAM-3355] Diagnostic interfaces
URL: https://github.com/apache/beam/pull/4311#discussion_r179820369
 
 

 ##########
 File path: sdks/go/pkg/beam/model/pipeline_v1/beam_runner_api.pb.go
 ##########
 @@ -924,7 +924,7 @@ type PTransform struct {
        //
        Outputs map[string]string `protobuf:"bytes,4,rep,name=outputs" 
json:"outputs,omitempty" protobuf_key:"bytes,1,opt,name=key" 
protobuf_val:"bytes,2,opt,name=value"`
        // (Optional) Static display data for this PTransform application. If
-       // there is none, or it is not relevant (such as use by the Fn API)
 
 Review comment:
   Is this from a new go generate or a search'n'replace? If the latter, we 
should make the change to the proto file or revert.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 88513)
    Time Spent: 6h 40m  (was: 6.5h)

> Make Go SDK runtime harness hooks pluggable
> -------------------------------------------
>
>                 Key: BEAM-3355
>                 URL: https://issues.apache.org/jira/browse/BEAM-3355
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Bill Neubauer
>            Priority: Minor
>          Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> We currently hardcode cpu profiling and session recording in the harness. We 
> should make it pluggable instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to