[ 
https://issues.apache.org/jira/browse/BEAM-4038?focusedWorklogId=92037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92037
 ]

ASF GitHub Bot logged work on BEAM-4038:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Apr/18 03:25
            Start Date: 18/Apr/18 03:25
    Worklog Time Spent: 10m 
      Work Description: rangadi commented on a change in pull request #5111: 
[BEAM-4038] Support Kafka Headers in KafkaIO
URL: https://github.com/apache/beam/pull/5111#discussion_r182297723
 
 

 ##########
 File path: 
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecord.java
 ##########
 @@ -76,6 +80,10 @@ public long getOffset() {
     return offset;
   }
 
+  public Headers getHeaders() {
 
 Review comment:
   I think this should throw an exception if 'hasHeaders' is false. We don't 
need the user to worry about null values. `ConsumerRecord.headers` is not 
expected to be null either. We can do this once we know the current solution 
works as expected with older kafka-clients versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 92037)
    Time Spent: 5h 50m  (was: 5h 40m)

> Support Kafka Headers in KafkaIO
> --------------------------------
>
>                 Key: BEAM-4038
>                 URL: https://issues.apache.org/jira/browse/BEAM-4038
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-kafka
>            Reporter: Geet Kumar
>            Assignee: Raghu Angadi
>            Priority: Minor
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> Headers have been added to Kafka Consumer/Producer records (KAFKA-4208). The 
> purpose of this JIRA is to support this feature in KafkaIO.  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to