[
https://issues.apache.org/jira/browse/BEAM-4038?focusedWorklogId=92322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92322
]
ASF GitHub Bot logged work on BEAM-4038:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 01:12
Start Date: 19/Apr/18 01:12
Worklog Time Spent: 10m
Work Description: gkumar7 commented on a change in pull request #5111:
[BEAM-4038] Support Kafka Headers in KafkaIO
URL: https://github.com/apache/beam/pull/5111#discussion_r182611605
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecord.java
##########
@@ -33,6 +34,7 @@
private final String topic;
private final int partition;
private final long offset;
+ private final Headers headers;
Review comment:
Thank you for sharing this. Yes, this works as expected, but the issue comes
when we initialize Headers in the if branch like so (similar to my example):
```java
if (isPresent && kafkaHeaders == null) {
Headers headers = new RecordHeaders();
headers.add("headerKey", "headerVal".getBytes());
return new ConsumerRecord<>("test", 0, 0L, "key", "value").headers();
}
```
Even with is.present set to False, this throws a runtime exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92322)
Time Spent: 6h 10m (was: 6h)
> Support Kafka Headers in KafkaIO
> --------------------------------
>
> Key: BEAM-4038
> URL: https://issues.apache.org/jira/browse/BEAM-4038
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Geet Kumar
> Assignee: Raghu Angadi
> Priority: Minor
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Headers have been added to Kafka Consumer/Producer records (KAFKA-4208). The
> purpose of this JIRA is to support this feature in KafkaIO.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
