[
https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=92906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92906
]
ASF GitHub Bot logged work on BEAM-3303:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 23:18
Start Date: 19/Apr/18 23:18
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #5179:
[BEAM-3303] Add Go Windowing support
URL: https://github.com/apache/beam/pull/5179#discussion_r182910776
##########
File path: sdks/go/pkg/beam/core/runtime/exec/window.go
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package exec
+
+import (
+ "context"
+ "fmt"
+ "time"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/mtime"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/window"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+)
+
+// WindowInto places each element in one or more windows.
+type WindowInto struct {
+ UID UnitID
+ Fn *window.Fn
+ Out Node
+}
+
+func (w *WindowInto) ID() UnitID {
+ return w.UID
+}
+
+func (w *WindowInto) Up(ctx context.Context) error {
+ return nil
+}
+
+func (w *WindowInto) StartBundle(ctx context.Context, id string, data
DataManager) error {
+ return w.Out.StartBundle(ctx, id, data)
+}
+
+func (w *WindowInto) ProcessElement(ctx context.Context, elm FullValue, values
...ReStream) error {
+ windowed := FullValue{
+ Windows: assignWindows(w.Fn, elm.Timestamp),
+ Timestamp: elm.Timestamp,
+ Elm: elm.Elm,
+ Elm2: elm.Elm2,
+ }
+ return w.Out.ProcessElement(ctx, windowed, values...)
+}
+
+func assignWindows(wfn *window.Fn, ts typex.EventTime) []typex.Window {
+ switch wfn.Kind {
+ case window.GlobalWindows:
+ return window.SingleGlobalWindow
+
+ case window.FixedWindows:
+ start := ts - (ts.Add(wfn.Size) % mtime.FromDuration(wfn.Size))
+ end := mtime.Min(start.Add(wfn.Size),
mtime.EndOfGlobalWindowTime.Add(time.Millisecond))
+ return []typex.Window{window.IntervalWindow{Start: start, End:
end}}
+
+ case window.SlidingWindows:
+ var ret []typex.Window
+
+ period := mtime.FromDuration(wfn.Period)
+ lastStart := ts - (ts.Add(wfn.Size) % period)
+ for start := lastStart; start > ts.Subtract(wfn.Size); start -=
period {
+ ret = append(ret, window.IntervalWindow{Start: start,
End: start.Add(wfn.Size)})
+ }
+ return ret
+
+ default:
Review comment:
<!--new_thread; commit:81c235c706bd235485cd974fce2b98c97a05e64e;
resolved:0-->
Is there a TODO /JIRA for the Session window support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92906)
Time Spent: 1h (was: 50m)
> Go windowing support
> --------------------
>
> Key: BEAM-3303
> URL: https://issues.apache.org/jira/browse/BEAM-3303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add support for Window.into and windowing strategies on Node. Implement the
> various windowing strategies Beam has: GlobalWindow, FixedWindows, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
