[ https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=92909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92909 ]
ASF GitHub Bot logged work on BEAM-3303: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Apr/18 23:18 Start Date: 19/Apr/18 23:18 Worklog Time Spent: 10m Work Description: lostluck commented on a change in pull request #5179: [BEAM-3303] Add Go Windowing support URL: https://github.com/apache/beam/pull/5179#discussion_r182910787 ########## File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go ########## @@ -95,26 +96,56 @@ func (n *ParDo) ProcessElement(ctx context.Context, elm FullValue, values ...ReS } ctx = metrics.SetPTransformID(ctx, n.PID) + fn := n.Fn.ProcessElementFn() - val, err := n.invokeDataFn(ctx, elm.Timestamp, n.Fn.ProcessElementFn(), &MainInput{Key: elm, Values: values}) - if err != nil { - return n.fail(err) - } + // If the function observes windows, we must pass invoke the it for each window. The expected fast path Review comment: <!--new_thread; commit:6ee6d36955135af80b8e1e548d1c0d9a5525c2b7; resolved:0--> s/the it/it/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 92909) Time Spent: 1h 10m (was: 1h) > Go windowing support > -------------------- > > Key: BEAM-3303 > URL: https://issues.apache.org/jira/browse/BEAM-3303 > Project: Beam > Issue Type: Improvement > Components: sdk-go > Reporter: Henning Rohde > Assignee: Henning Rohde > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Add support for Window.into and windowing strategies on Node. Implement the > various windowing strategies Beam has: GlobalWindow, FixedWindows, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)