[
https://issues.apache.org/jira/browse/BEAM-4449?focusedWorklogId=110170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110170
]
ASF GitHub Bot logged work on BEAM-4449:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/18 17:16
Start Date: 08/Jun/18 17:16
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5544: [BEAM-4449] Replace project and filter with calc
URL: https://github.com/apache/beam/pull/5544#discussion_r194123274
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlExpressionExecutor.java
##########
@@ -33,8 +32,7 @@
void prepare();
/** apply transformation to input record {@link Row} with {@link
BoundedWindow}. */
- List<Object> execute(
- Row inputRow, BoundedWindow window, ImmutableMap<Integer, Object>
correlateEnv);
+ List<Object> execute(Row inputRow, BoundedWindow window,
BeamSqlExpressionEnvironment env);
Review comment:
The row and window are now in the env also so this is redundant, but I'd
rather do the fancy regexing and whatnot separate from this functional PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 110170)
Time Spent: 4.5h (was: 4h 20m)
> Use Calc instead of Project and Filter separately
> -------------------------------------------------
>
> Key: BEAM-4449
> URL: https://issues.apache.org/jira/browse/BEAM-4449
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Calcite has a combined Calc operator that is amenable to more optimization,
> and also means less code to manage as we adjust how the operators/expressions
> are implemented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
