[
https://issues.apache.org/jira/browse/BEAM-4449?focusedWorklogId=110171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110171
]
ASF GitHub Bot logged work on BEAM-4449:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/18 17:16
Start Date: 08/Jun/18 17:16
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5544: [BEAM-4449] Replace project and filter with calc
URL: https://github.com/apache/beam/pull/5544#discussion_r194123048
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlExpressionEnvironment.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.impl.interpreter;
+
+import java.util.List;
+import
org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.BeamSqlExpression;
+import
org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.BeamSqlPrimitive;
+import org.apache.beam.sdk.values.Row;
+
+/**
+ * Environment in which a {@link BeamSqlExpression} is evaluated. This
includes bindings of
+ * correlation variables and local references.
+ */
+public interface BeamSqlExpressionEnvironment {
+
+ /** Gets the value for a local variable reference. */
+ BeamSqlPrimitive<?> getLocalRef(int localRefIndex);
Review comment:
@akedin from your advice on lazy eval, this is now an immutable interface w/
mutation under the hood.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 110171)
Time Spent: 4h 40m (was: 4.5h)
> Use Calc instead of Project and Filter separately
> -------------------------------------------------
>
> Key: BEAM-4449
> URL: https://issues.apache.org/jira/browse/BEAM-4449
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Calcite has a combined Calc operator that is amenable to more optimization,
> and also means less code to manage as we adjust how the operators/expressions
> are implemented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
