[
https://issues.apache.org/jira/browse/BEAM-4526?focusedWorklogId=110377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110377
]
ASF GitHub Bot logged work on BEAM-4526:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/18 04:22
Start Date: 09/Jun/18 04:22
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5597:
[BEAM-4526] Suppress immutability warning caused by LoadingCache in enum
instance
URL: https://github.com/apache/beam/pull/5597
This is currently breaking precommit on master. The two options are to
suppress it or not use an `enum`. My impression is that the code in question is
trying to be too clever about ensuring the singleton is really a singleton,
which can be done in other ways.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 110377)
Time Spent: 10m
Remaining Estimate: 0h
> FlinkRunner failing errorprone due to mutable enum
> --------------------------------------------------
>
> Key: BEAM-4526
> URL: https://issues.apache.org/jira/browse/BEAM-4526
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/BatchFlinkExecutableStageContext.java:77:
> warning: [ImmutableEnumChecker] enums should be immutable: 'BatchFactory'
> has field 'cachedContexts' of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>',
> the declaration of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>'
> is not annotated with @com.google.errorprone.annotations.Immutable or
> @javax.annotation.concurrent.Immutable
> private final LoadingCache<JobInfo, BatchFlinkExecutableStageContext>
> cachedContexts;
> ^
> (see http://errorprone.info/bugpattern/ImmutableEnumChecker)
> error: warnings found and -Werror specified
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
