[
https://issues.apache.org/jira/browse/BEAM-4481?focusedWorklogId=111571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111571
]
ASF GitHub Bot logged work on BEAM-4481:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 17:32
Start Date: 13/Jun/18 17:32
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5594:
[BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have
dependency conflicts
URL: https://github.com/apache/beam/pull/5594#discussion_r195172189
##########
File path: build_rules.gradle
##########
@@ -1253,6 +1254,125 @@ ext.applyGrpcNature = {
/*************************************************************************************************/
+ext.applyPortabilityNature = {
+ println "applyPortabilityNature with " + (it ? "$it" : "default
configuration") + " for project $project.name"
+ applyJavaNature(enableFindbugs: false, enableErrorProne: false,
shadowClosure: {
Review comment:
If that's the case, can we make `failOnWarning: true`? Eventually we want to
remove the switch altogether and make failOnWarning default; if these projects
are only generated code then I wouldn't expect to get any violations anyway.
ErrorProne is configured to ignore generated code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111571)
Time Spent: 5h 10m (was: 5h)
> Remove duplicate dependency declarations from runners/direct-java
> -----------------------------------------------------------------
>
> Key: BEAM-4481
> URL: https://issues.apache.org/jira/browse/BEAM-4481
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> beam-model-pipeline and others are duplicated in the dependency list
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
