[
https://issues.apache.org/jira/browse/BEAM-4481?focusedWorklogId=111595&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111595
]
ASF GitHub Bot logged work on BEAM-4481:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 18:31
Start Date: 13/Jun/18 18:31
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5594:
[BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have
dependency conflicts
URL: https://github.com/apache/beam/pull/5594#discussion_r195184085
##########
File path: build_rules.gradle
##########
@@ -1260,6 +1261,146 @@ ext.applyGrpcNature = {
/*************************************************************************************************/
+ext.applyPortabilityNature = {
+ println "applyPortabilityNature with " + (it ? "$it" : "default
configuration") + " for project $project.name"
+ applyJavaNature(failOnWarning: true, enableFindbugs: false, shadowClosure: {
+ // The relocation paths below specifically use the major version number of
the dependency
+ // since we assume that packages following semantic versioning rules. For
packages
+ // with a major version number that is 0 (implying that the dependency is
unstable),
+ // we use the full version identifier in the relocated path (e.g.
v0_minor_patch).
+ // For stable dependencies, if two or more packages use the same major
version number,
Review comment:
Thanks for writing this extensive documentation. This will be a useful
reference for anyone that needs to maintain dependencies.
Could you define what you mean by "stable dependencies"; in contrast to
those which change more frequently?
It may also be useful to talk about the implications of having multiple
versions of a dependency. IMO shading is one of the more
difficult-to-understand areas of the Beam codebase, so I welcome any
documentation that helps explain how we use it. This may even deserve separate
markdown doc or wiki page.
Just my 2cents. Feel free to disagree or defer to later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 111595)
Time Spent: 6h 10m (was: 6h)
> Remove duplicate dependency declarations from runners/direct-java
> -----------------------------------------------------------------
>
> Key: BEAM-4481
> URL: https://issues.apache.org/jira/browse/BEAM-4481
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> beam-model-pipeline and others are duplicated in the dependency list
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
