[
https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=112150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112150
]
ASF GitHub Bot logged work on BEAM-4003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/18 03:34
Start Date: 15/Jun/18 03:34
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5373:
[BEAM-4003] Futurize runners subpackage
URL: https://github.com/apache/beam/pull/5373#discussion_r195622728
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -22,8 +22,13 @@
For internal use only; no backwards-compatibility guarantees.
"""
+from __future__ import absolute_import
+
import sys
import traceback
+from builtins import next
+from builtins import object
+from builtins import zip
import six
Review comment:
I think we should we avoid `import six` for consistency with the approach
followed elsewhere.
What do you think, @RobbeSneyders ?
Looks like we are using `six.reraise` in a few places and `six.text_type` in
apiclient.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 112150)
Time Spent: 40m (was: 0.5h)
> Futurize and fix python 2 compatibility for runners subpackage
> --------------------------------------------------------------
>
> Key: BEAM-4003
> URL: https://issues.apache.org/jira/browse/BEAM-4003
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
