[
https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=112161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112161
]
ASF GitHub Bot logged work on BEAM-4003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/18 03:34
Start Date: 15/Jun/18 03:34
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5373:
[BEAM-4003] Futurize runners subpackage
URL: https://github.com/apache/beam/pull/5373#discussion_r195526003
##########
File path: sdks/python/apache_beam/runners/direct/evaluation_context.py
##########
@@ -80,8 +81,8 @@ def __init__(self, side_inputs):
self._transform_to_side_inputs[side.pvalue.producer].append(side)
def __repr__(self):
- views_string = (', '.join(str(elm) for elm in self._views.values())
- if self._views.values() else '[]')
+ views_string = (', '.join(str(elm) for elm in list(self._views.values()))
+ if list(self._views.values()) else '[]')
Review comment:
While technically this makes equivalent interpretation in Py2 and Py3, I
think we can safely skip list conversion here in favor of cleaner code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 112161)
Time Spent: 1h 50m (was: 1h 40m)
> Futurize and fix python 2 compatibility for runners subpackage
> --------------------------------------------------------------
>
> Key: BEAM-4003
> URL: https://issues.apache.org/jira/browse/BEAM-4003
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
