[
https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=118522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118522
]
ASF GitHub Bot logged work on BEAM-4003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 01:05
Start Date: 03/Jul/18 01:05
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5373: [BEAM-4003] Futurize runners subpackage
URL: https://github.com/apache/beam/pull/5373#discussion_r199658941
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -23,21 +23,27 @@
import abc
import contextlib
import logging
-import Queue as queue
+import queue
import sys
import threading
import traceback
+from builtins import object
+from builtins import range
from concurrent import futures
import grpc
-import six
+from future import standard_library
+from future.utils import raise_
+from future.utils import with_metaclass
from apache_beam.portability.api import beam_fn_api_pb2
from apache_beam.portability.api import beam_fn_api_pb2_grpc
from apache_beam.runners.worker import bundle_processor
from apache_beam.runners.worker import data_plane
from apache_beam.runners.worker.worker_id_interceptor import
WorkerIdInterceptor
+standard_library.install_aliases()
Review comment:
Do we want to call this before we do the import of "queue" above? It looks
like this only works because of an "accident" in that this module is imported
after someone else already called `install_aliases()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118522)
Time Spent: 3.5h (was: 3h 20m)
> Futurize and fix python 2 compatibility for runners subpackage
> --------------------------------------------------------------
>
> Key: BEAM-4003
> URL: https://issues.apache.org/jira/browse/BEAM-4003
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
