[ https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=118536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118536 ]
ASF GitHub Bot logged work on BEAM-4003: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Jul/18 01:05 Start Date: 03/Jul/18 01:05 Worklog Time Spent: 10m Work Description: charlesccychen commented on a change in pull request #5373: [BEAM-4003] Futurize runners subpackage URL: https://github.com/apache/beam/pull/5373#discussion_r199659436 ########## File path: sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/message_matchers.py ########## @@ -49,7 +51,7 @@ def _matches(self, item): if self.origin != IGNORED and item.origin != self.origin: return False if self.context != IGNORED: - for key, name in self.context.iteritems(): + for key, name in iteritems(self.context): Review comment: Why `iteritems` here vs `.items()`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 118536) Time Spent: 5h 20m (was: 5h 10m) > Futurize and fix python 2 compatibility for runners subpackage > -------------------------------------------------------------- > > Key: BEAM-4003 > URL: https://issues.apache.org/jira/browse/BEAM-4003 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Matthias Feys > Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)