[ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=126800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126800 ]
ASF GitHub Bot logged work on BEAM-4176: ---------------------------------------- Author: ASF GitHub Bot Created on: 24/Jul/18 19:03 Start Date: 24/Jul/18 19:03 Worklog Time Spent: 10m Work Description: angoenka commented on a change in pull request #5935: [BEAM-4176] Initial implementation for running portable runner tests URL: https://github.com/apache/beam/pull/5935#discussion_r204858083 ########## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java ########## @@ -109,28 +120,63 @@ private FlinkJobServerDriver( @Override public void run() { try { - GrpcFnServer<InMemoryJobService> server = createJobServer(); - server.getServer().awaitTermination(); + jobServer = createJobServer(); + jobServer.getServer().awaitTermination(); } catch (InterruptedException e) { LOG.warn("Job server interrupted", e); } catch (Exception e) { LOG.warn("Exception during job server creation", e); + } finally { + stop(); + } + } + + public String start() throws IOException { + jobServer = createJobServer(); + return jobServer.getApiServiceDescriptor().getUrl(); + } + + public void stop() { + if (jobServer != null) { + try { + jobServer.close(); + LOG.info("JobServer stopped on {}", jobServer.getApiServiceDescriptor().getUrl()); + jobServer = null; + } catch (Exception e) { + LOG.error("Error while closing the jobServer."); Review comment: SG ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 126800) Time Spent: 3h 40m (was: 3.5h) > Java: Portable batch runner passes all ValidatesRunner tests that > non-portable runner passes > -------------------------------------------------------------------------------------------- > > Key: BEAM-4176 > URL: https://issues.apache.org/jira/browse/BEAM-4176 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Ben Sidhom > Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > We need this as a sanity check that runner execution is correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)