[ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=127525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127525 ]
ASF GitHub Bot logged work on BEAM-4176: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/Jul/18 21:45 Start Date: 25/Jul/18 21:45 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5935: [BEAM-4176] Initial implementation for running portable runner tests URL: https://github.com/apache/beam/pull/5935#discussion_r205272392 ########## File path: runners/reference/java/src/main/java/org/apache/beam/runners/reference/testing/TestPortableRunner.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.reference.testing; + +import static org.hamcrest.MatcherAssert.assertThat; + +import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; +import org.apache.beam.runners.reference.PortableRunner; +import org.apache.beam.sdk.Pipeline; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.PipelineResult.State; +import org.apache.beam.sdk.PipelineRunner; +import org.apache.beam.sdk.options.PipelineOptions; +import org.apache.beam.sdk.options.PortablePipelineOptions; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.util.common.ReflectHelpers; +import org.hamcrest.Matchers; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * {@link TestPortableRunner} is a pipeline runner that wraps a {@link PortableRunner} when running + * tests against the {@link TestPipeline}. + * + * <p>This runner requires a JobServerDriver with following methods. Review comment: I believe the issue is that TestPortableRunner shouldn't be part of the reference runner subproject but in a place where every runner could refer to it. SGTM as a change in a subsequent PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 127525) Time Spent: 5h 10m (was: 5h) > Java: Portable batch runner passes all ValidatesRunner tests that > non-portable runner passes > -------------------------------------------------------------------------------------------- > > Key: BEAM-4176 > URL: https://issues.apache.org/jira/browse/BEAM-4176 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Ben Sidhom > Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > We need this as a sanity check that runner execution is correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)