[
https://issues.apache.org/jira/browse/BEAM-3709?focusedWorklogId=132736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132736
]
ASF GitHub Bot logged work on BEAM-3709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 22:53
Start Date: 08/Aug/18 22:53
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6128:
[BEAM-3709] Updating combine w/ side input translation in python.
URL: https://github.com/apache/beam/pull/6128#discussion_r208760825
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1358,6 +1358,11 @@ def expand(self, pcoll):
*args, **kwargs)
def to_runner_api_parameter(self, context):
+ if self.side_inputs:
Review comment:
This looks right to me. I have not realized before that using side inputs
will prevent lifting but it makes sense.
However, I do not think this is clean. Because the next if self.args or
self.kwargs is also practically checking for the same thing. args and kwargs
are used for passing side inputs and do not have another purpose
(https://github.com/apache/beam/blob/e69a353c94d0a54d3f7194736433e4dbac87303f/sdks/python/apache_beam/transforms/core.py#L1251)
You probably need to edit that if instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 132736)
Time Spent: 2h 20m (was: 2h 10m)
> Implement the portable lifted Combiner transforms in Python SDK
> ---------------------------------------------------------------
>
> Key: BEAM-3709
> URL: https://issues.apache.org/jira/browse/BEAM-3709
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, sdk-py-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Python SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
