[
https://issues.apache.org/jira/browse/BEAM-3286?focusedWorklogId=133289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133289
]
ASF GitHub Bot logged work on BEAM-3286:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/18 21:36
Start Date: 09/Aug/18 21:36
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #6197:
[BEAM-3286] Add preliminary Go support for side input
URL: https://github.com/apache/beam/pull/6197#discussion_r209079934
##########
File path: sdks/go/pkg/beam/core/runtime/harness/datamgr.go
##########
@@ -25,46 +25,78 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/core/runtime/exec"
"github.com/apache/beam/sdks/go/pkg/beam/log"
pb "github.com/apache/beam/sdks/go/pkg/beam/model/fnexecution_v1"
- "google.golang.org/grpc"
)
const (
chunkSize = int(4e6) // Bytes to put in a single gRPC message. Max is
slightly higher.
bufElements = 20 // Number of chunks buffered per reader.
)
-// This is a reduced version of the full gRPC interface to help with testing.
-// TODO(wcn): need a compile-time assertion to make sure this stays synced
with what's
-// in pb.BeamFnData_DataClient
-type dataClient interface {
- Send(*pb.Elements) error
- Recv() (*pb.Elements, error)
+// ScopedDataManager scopes the global gRPC data manager to a single
instruction.
+// The indirection makes it easier to control access.
+type ScopedDataManager struct {
Review comment:
This is only used within the same package, consider not exporting it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 133289)
Time Spent: 1h (was: 50m)
> Go SDK support for portable side input
> --------------------------------------
>
> Key: BEAM-3286
> URL: https://issues.apache.org/jira/browse/BEAM-3286
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
