[
https://issues.apache.org/jira/browse/BEAM-3286?focusedWorklogId=135919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135919
]
ASF GitHub Bot logged work on BEAM-3286:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/18 23:24
Start Date: 17/Aug/18 23:24
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #6197:
[BEAM-3286] Add preliminary Go support for side input
URL: https://github.com/apache/beam/pull/6197#discussion_r211052736
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/sideinput.go
##########
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package graphx
+
+import (
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/coder"
+)
+
+// Side input support
+//
+// The Beam model supports only MultiMap side input, so for
+// iterable side input (= the only kind in Go so far) we must
+// implicitly use a fixed key (""). We use a special execution
+// unit as well to handle nested KVs.
+
+const (
+ URNIterableSideInputKey = "beam:go:transform:iterablesideinputkey:v1"
+)
+
+// MakeBytesKeyedCoder returns KV<[]byte,A,> for any coder,
+// even if the coder is already a KV coder.
+func MakeBytesKeyedCoder(c *coder.Coder) *coder.Coder {
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 135919)
Time Spent: 1h 50m (was: 1h 40m)
> Go SDK support for portable side input
> --------------------------------------
>
> Key: BEAM-3286
> URL: https://issues.apache.org/jira/browse/BEAM-3286
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
