[
https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=135718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135718
]
ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/18 15:10
Start Date: 17/Aug/18 15:10
Worklog Time Spent: 10m
Work Description: aalbatross commented on a change in pull request #6146:
[BEAM-3026] Adding retrying behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#discussion_r210941303
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/common/retry/BaseRetryConfiguration.java
##########
@@ -0,0 +1,52 @@
+/*
Review comment:
@timrobertson100 @echauchot i agree moving withRetryPredicate to
BaseRetryConfiguration will expose API, the only way i can avoid it is by
overriding the method with protected final key word in ESIO or SolrIO. This
will lead to duplicate code in all the implementations which use the common
configuration classes.
I think it is better to have duplicates with AutoValue Builder in ESIO and
SolrIO instead of using common config objects. I will remove common code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 135718)
Time Spent: 9h 50m (was: 9h 40m)
> Improve retrying in ElasticSearch client
> ----------------------------------------
>
> Key: BEAM-3026
> URL: https://issues.apache.org/jira/browse/BEAM-3026
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Tim Robertson
> Assignee: Ravi Pathak
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses. Perhaps something like this:
> {code}
> ElasticsearchIO.ConnectionConfiguration conn =
> ElasticsearchIO.ConnectionConfiguration
> .create(new String[]{"http://...:9200"}, "test", "test")
> .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000,
> TimeUnit.MILLISECONDS)
> .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
> );
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
