[ https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=136525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136525 ]
ASF GitHub Bot logged work on BEAM-3026: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Aug/18 14:07 Start Date: 21/Aug/18 14:07 Worklog Time Spent: 10m Work Description: echauchot commented on a change in pull request #6146: [BEAM-3026] Adding retrying behavior on ElasticSearchIO URL: https://github.com/apache/beam/pull/6146#discussion_r211619094 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/common/retry/RetryConfiguration.java ########## @@ -0,0 +1,80 @@ +package org.apache.beam.sdk.io.common.retry; + +import static com.google.common.base.Preconditions.checkArgument; + +import java.io.Serializable; +import org.joda.time.Duration; + +/** + * A POJO encapsulating a configuration for retry behavior when issuing requests. A retry will be + * attempted until the maxAttempts or maxDuration is exceeded, whichever comes first, for any of the + * following exceptions: + */ +public class RetryConfiguration implements Serializable { + + private int maxAttempts; + private Duration maxDuration; + private RetryPredicate retryPredicate; Review comment: +1 to that, indeed you described well the no knobs philosophy of Beam ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 136525) Time Spent: 10.5h (was: 10h 20m) > Improve retrying in ElasticSearch client > ---------------------------------------- > > Key: BEAM-3026 > URL: https://issues.apache.org/jira/browse/BEAM-3026 > Project: Beam > Issue Type: Improvement > Components: io-java-elasticsearch > Reporter: Tim Robertson > Assignee: Ravi Pathak > Priority: Major > Fix For: 2.7.0 > > Time Spent: 10.5h > Remaining Estimate: 0h > > Currently an overloaded ES server will result in clients failing fast. > I suggest implementing backoff pauses. Perhaps something like this: > {code} > ElasticsearchIO.ConnectionConfiguration conn = > ElasticsearchIO.ConnectionConfiguration > .create(new String[]{"http://...:9200"}, "test", "test") > .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000, > TimeUnit.MILLISECONDS) > .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10) > ); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)