[jira] [Work logged] (BEAM-3026) Improve retrying in ElasticSearch client

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=136884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136884
 ]

ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/18 10:22
            Start Date: 22/Aug/18 10:22
    Worklog Time Spent: 10m 
      Work Description: aalbatross edited a comment on issue #6146: [BEAM-3026] 
Adding retrying behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#issuecomment-414956841
 
 
   @echauchot 
   I updated the changes
   a. added constants for test cases
   b. removed fail(), could not remove try-catch block as i need to assert 
against cause of exception (which is IOException), so keeping it unchanged.
   
   If there is a way i can start IT on jenkins ?
   I ran IT locally on my laptop sharing the screen shot here. 
   <img width="1680" alt="screen shot 2018-08-22 at 12 17 06" 
src="https://user-images.githubusercontent.com/1793534/44458189-b9f9c000-a605-11e8-85ed-f45a0d6c73ee.png";>
   <img width="1680" alt="screen shot 2018-08-22 at 12 11 49" 
src="https://user-images.githubusercontent.com/1793534/44458190-b9f9c000-a605-11e8-8043-41b2b3f9a084.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136884)
    Time Spent: 12h 40m  (was: 12.5h)

> Improve retrying in ElasticSearch client
> ----------------------------------------
>
>                 Key: BEAM-3026
>                 URL: https://issues.apache.org/jira/browse/BEAM-3026
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Tim Robertson
>            Assignee: Ravi Pathak
>            Priority: Major
>             Fix For: 2.7.0
>
>          Time Spent: 12h 40m
>  Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses.  Perhaps something like this:
> {code}
>     ElasticsearchIO.ConnectionConfiguration conn = 
> ElasticsearchIO.ConnectionConfiguration
>       .create(new String[]{"http://...:9200"}, "test", "test")
>       .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000, 
> TimeUnit.MILLISECONDS)
>       .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
>     );
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)