[ 
https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=137284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137284
 ]

ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Aug/18 08:23
            Start Date: 23/Aug/18 08:23
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on issue #6146: [BEAM-3026] Adding 
retrying behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#issuecomment-415334024
 
 
   @aalbatross thanks for the changes
   1. for running IT from the PR: it requires to create a new jenkins job. 
There is a ticket open for that.
   2. for ITests failures: write errors are due to a saturation of the bulk 
thread pool. I guess you use a local ES created by the docker script I 
provided? You need to configure the instance and raise the thread pool size 
(param `thread_pool.bulk.queue_size`). This is not a good thing to do in 
production, but in test it is OK. UTests define this value to 400.
   3. for UTests failure they are unrelated to this PR (apex related) and ES 
tests execute fine so it is ok for me 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 137284)
    Time Spent: 12h 50m  (was: 12h 40m)

> Improve retrying in ElasticSearch client
> ----------------------------------------
>
>                 Key: BEAM-3026
>                 URL: https://issues.apache.org/jira/browse/BEAM-3026
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Tim Robertson
>            Assignee: Ravi Pathak
>            Priority: Major
>             Fix For: 2.7.0
>
>          Time Spent: 12h 50m
>  Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses.  Perhaps something like this:
> {code}
>     ElasticsearchIO.ConnectionConfiguration conn = 
> ElasticsearchIO.ConnectionConfiguration
>       .create(new String[]{"http://...:9200"}, "test", "test")
>       .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000, 
> TimeUnit.MILLISECONDS)
>       .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
>     );
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to