[ https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=136969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136969 ]
ASF GitHub Bot logged work on BEAM-5107: ---------------------------------------- Author: ASF GitHub Bot Created on: 22/Aug/18 14:47 Start Date: 22/Aug/18 14:47 Worklog Time Spent: 10m Work Description: echauchot commented on a change in pull request #6211: [BEAM-5107] Support ES-6.x for ElasticsearchIO URL: https://github.com/apache/beam/pull/6211#discussion_r211890438 ########## File path: sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java ########## @@ -125,7 +125,8 @@ * * <p>Optionally, you can provide {@link ElasticsearchIO.Write.FieldValueExtractFn} using {@code * withIndexFn()} or {@code withTypeFn()} to enable per-document routing to the target Elasticsearch - * index and type. + * index (all versions) and type (version <6). Support for type routing was removed in Elasticsearch + * 6 (see https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch) Review comment: Good catch ! That being said, there is not only type routing that will be removed but all the type feature in ES ! It will be removed in 7.0. As we know the IO will break in 7.0 I prefer that you put `version == 5 || version == 6` everywhere you put `version >= 5` to avoid that the users use the IO on incompatible ES v7. We will then do another PR to support ES v7 on the IO. I just opened this ticket to track the future migration: https://issues.apache.org/jira/browse/BEAM-5192. @timrobertson100 I assigned it to you regarding our conversation of yesterday. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 136969) Time Spent: 6h 40m (was: 6.5h) > Support ES 6.x for ElasticsearchIO > ---------------------------------- > > Key: BEAM-5107 > URL: https://issues.apache.org/jira/browse/BEAM-5107 > Project: Beam > Issue Type: Improvement > Components: io-java-elasticsearch > Reporter: Dat Tran > Assignee: Etienne Chauchot > Priority: Major > Time Spent: 6h 40m > Remaining Estimate: 0h > > Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x. > We should support ES 6.x for ElasticsearchIO. > https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html > https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)