[
https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=139192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139192
]
ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/18 09:40
Start Date: 29/Aug/18 09:40
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #6211:
[BEAM-5107] Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#discussion_r213607551
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOIT.java
##########
@@ -93,24 +86,7 @@ public static void afterClass() throws Exception {
@Test
public void testSplitsVolume() throws Exception {
Review comment:
There is no more point having a separate testSplitVolume. Only one
testSplit method is enough. The only difference between the 2 methods is
desiredBundleSizeBytes = 10000. You can add this line to an else in `if
(!useAsITests)` in testSplit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 139192)
Time Spent: 8h 10m (was: 8h)
> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-5107
> URL: https://issues.apache.org/jira/browse/BEAM-5107
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Dat Tran
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
