[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=144775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144775
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/18 09:50
Start Date: 17/Sep/18 09:50
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6381:
[BEAM-5299] Define max timestamp for global window in proto
URL: https://github.com/apache/beam/pull/6381#discussion_r218003760
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -32,6 +32,16 @@ option java_outer_classname = "RunnerApi";
import "google/protobuf/any.proto";
import "google/protobuf/descriptor.proto";
+message BeamConstants {
+ enum Constants {
+ // The maximum timestamp for the global window in milliseconds since Jan
1, 1970
+ // Triggers use maxTimestamp to set timers' timestamp. Timers fires when
+ // the watermark passes their timestamps. So, the timestamp needs to be
+ // smaller than the TIMESTAMP_MAX_MILLIS.
+ GLOBAL_WINDOW_MAX_TIMESTAMP_MILLIS = 0 [(beam_constant) =
"9223371950454775"];
Review comment:
Totally agree it is arbitrary, but wouldn't MAX_TIMESTAMP/2 be arbitrary as
well? I suppose it would be more explicitly arbitrary :) I added a comment
where this is coming from.
Hex representation does save as some bytes (precisely four).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144775)
Time Spent: 0.5h (was: 20m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
