[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=146030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146030
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/18 14:27
Start Date: 20/Sep/18 14:27
Worklog Time Spent: 10m
Work Description: ryan-williams commented on a change in pull request
#6381: [BEAM-5299] Define max timestamp for global window in proto
URL: https://github.com/apache/beam/pull/6381#discussion_r219185494
##########
File path: sdks/java/core/build.gradle
##########
@@ -51,6 +51,8 @@ test {
}
dependencies {
+ // Required to loads constants from the model, e.g. max timestamp for global
window
+ shadow project(path: ":beam-model-pipeline", configuration: "shadow")
Review comment:
thanks for that context!
"propose" is too strong; maybe if creating/maintaining more modules were
free, then the leanest possible dependency structure would be nice, but I don't
think that makes sense here.
I mostly just wanted to talk through the module/dependency structure a bit.
I probably need to dump it into a dot graph to really get it 😄 (aside: the
existing visteg graphs i see generated [are fairly
uninformative](https://cl.ly/153a4d17ce84/Screen%20Shot%202018-09-20%20at%2010.25.12%20AM.png))
anyway, no objections here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 146030)
Time Spent: 2h (was: 1h 50m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
