[ 
https://issues.apache.org/jira/browse/BEAM-5324?focusedWorklogId=145884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145884
 ]

ASF GitHub Bot logged work on BEAM-5324:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Sep/18 00:18
            Start Date: 20/Sep/18 00:18
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on a change in pull request #6424: 
[BEAM-5324] Partially port unpackaged modules to Python 3
URL: https://github.com/apache/beam/pull/6424#discussion_r219002007
 
 

 ##########
 File path: sdks/python/apache_beam/pipeline_test.py
 ##########
 @@ -520,13 +525,14 @@ def test_dir(self):
     options = Breakfast()
     self.assertEquals(
         set(['from_dictionary', 'get_all_options', 'slices', 'style',
-             'view_as', 'display_data', 'next']),
-        set([attr for attr in dir(options) if not attr.startswith('_')]))
+             'view_as', 'display_data']),
+        set([attr for attr in dir(options) if not attr.startswith('_') and
+             attr != 'next']))
 
 Review comment:
   What is special about 'next' ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145884)
    Time Spent: 1h 40m  (was: 1.5h)

> Finish Python 3 porting for unpackaged files
> --------------------------------------------
>
>                 Key: BEAM-5324
>                 URL: https://issues.apache.org/jira/browse/BEAM-5324
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to