[
https://issues.apache.org/jira/browse/BEAM-5324?focusedWorklogId=145942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145942
]
ASF GitHub Bot logged work on BEAM-5324:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/18 07:39
Start Date: 20/Sep/18 07:39
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#6424: [BEAM-5324] Partially port unpackaged modules to Python 3
URL: https://github.com/apache/beam/pull/6424#discussion_r219062545
##########
File path: sdks/python/apache_beam/runners/runner.py
##########
@@ -96,7 +96,7 @@ def create_runner(runner_name):
if '.' in runner_name:
module, runner = runner_name.rsplit('.', 1)
try:
- return getattr(__import__(module, {}, {}, [runner], -1), runner)()
+ return getattr(__import__(module, {}, {}, [runner], 0), runner)()
Review comment:
In Python 3.3+, the -1 option is not available anymore.
Looking at the
[_RUNNER_MAP](https://github.com/apache/beam/blob/363d3e385bdb9aca9f194a2b772038bc5db3cb5b/sdks/python/apache_beam/runners/runner.py#L40),
all defined runner paths are absolute anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 145942)
Time Spent: 2h 20m (was: 2h 10m)
> Finish Python 3 porting for unpackaged files
> --------------------------------------------
>
> Key: BEAM-5324
> URL: https://issues.apache.org/jira/browse/BEAM-5324
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
