EDjur commented on issue #11040: [BEAM-9305] Allow value provider query strings 
in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#issuecomment-595154066
 
 
   How about something like this instead @pabloem ? I noticed that 
`gcs_location`supports ValueProviders and is wrapped & initialised in the 
`_ReadFromBigQuery` transform. This reduces clutter in the 
`_CustomBigQuerySource`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to