kamilwu commented on a change in pull request #11040: [BEAM-9305] Allow value
provider query strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#discussion_r390250330
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
##########
@@ -156,12 +157,19 @@ def test_native_source(self):
@attr('IT')
def test_iobase_source(self):
+ query = StaticValueProvider(str, self.query)
with beam.Pipeline(argv=self.args) as p:
result = (
p | 'read' >> beam.io._ReadFromBigQuery(
query=self.query, use_standard_sql=True, project=self.project))
assert_that(result, equal_to(self.TABLE_DATA))
+ with beam.Pipeline(argv=self.args) as p:
Review comment:
@EDjur Thanks for explanation. That's right, if we want to check that query
is successfully evaluated to a string, we have to execute the pipeline.
@pabloem I think this is good idea. Let's do it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
