EDjur commented on a change in pull request #11040: [BEAM-9305] Allow value
provider query strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#discussion_r392122769
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -694,14 +699,16 @@ def read(self, range_tracker):
raise NotImplementedError('BigQuery source must be split before being
read')
def _setup_temporary_dataset(self, bq):
+ query = self.evaluate_query_valueprovider()
Review comment:
Thanks for the tip re: `check_accessible`, I didn't know about that. I've
updated the PR based on these suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
