rehmanmuradali commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601225409 > Could we ensure that the FnApiDoFnRunner implementation for the key is completed as well? > I think the type check for `@KeyId` breaks if the key is generic. I was trying this out and got: > > ``` > java.lang.IllegalArgumentException: CombinerDoFn, @OnTimer onTriggerTimer(BoundedWindow, WindowedKey, CombiningState, CombiningState, ValueState, CombiningState, BagState, OutputReceiver): @Key argument is expected to be type of WindowedKey<K>, but found class WindowedKey > ``` Thank you @steveniemitz for catching this bug. Can you please mention how can I reproduce it so that I can fix this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
