steveniemitz edited a comment on issue #11154: [BEAM-1819] Key should be 
available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#issuecomment-601243984
 
 
   seems like this is broken/unsupported in dataflow:
   
   ```
   java.lang.ClassCastException: java.lang.String cannot be cast to WindowedKey
           CombinerDoFn$OnTimerInvoker$t$dA.invokeOnTimer(Unknown Source)
           
org.apache.beam.sdk.transforms.reflect.ByteBuddyDoFnInvokerFactory$DoFnInvokerBase.invokeOnTimer(ByteBuddyDoFnInvokerFactory.java:229)
           
org.apache.beam.runners.dataflow.worker.repackaged.org.apache.beam.runners.core.SimpleDoFnRunner.onTimer(SimpleDoFnRunner.java:221)
           
org.apache.beam.runners.dataflow.worker.SimpleParDoFn.processUserTimer(SimpleParDoFn.java:373)
           
org.apache.beam.runners.dataflow.worker.SimpleParDoFn.access$600(SimpleParDoFn.java:74)
           
org.apache.beam.runners.dataflow.worker.SimpleParDoFn$TimerType$1.processTimer(SimpleParDoFn.java:458)
           
org.apache.beam.runners.dataflow.worker.SimpleParDoFn.processTimers(SimpleParDoFn.java:487)
           
org.apache.beam.runners.dataflow.worker.SimpleParDoFn.processTimers(SimpleParDoFn.java:365)
           
org.apache.beam.runners.dataflow.worker.util.common.worker.ParDoOperation.finish(ParDoOperation.java:52)
           
org.apache.beam.runners.dataflow.worker.util.common.worker.MapTaskExecutor.execute(MapTaskExecutor.java:85)
   ```
   
   (the generic parameter for my key isn't a string either).  I'm using a build 
of the dataflow worker jar from this branch as well, not the one bundled w/ the 
docker image.
   
   edit: 
   ah, I see 
[here](runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java)
 you're just passing an empty string in for the key.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to