[ https://issues.apache.org/jira/browse/BEAM-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232713#comment-15232713 ]
ASF GitHub Bot commented on BEAM-155: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/150 [BEAM-155] Make PassThroughWindowFn and NeverTrigger available Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace "<Jira issue #>" in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This will be used as part of the new PAssert PassThroughWindowFn remains package-private to restrict usage. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam pass_through_window_fn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 ---- commit 2d8189ff2948e8b294e253f087d741e4d122658b Author: Thomas Groh <tg...@google.com> Date: 2016-03-31T21:34:06Z Make PassThroughWindowFn and NeverTrigger available This will be used as part of the new PAssert PassThroughWindowFn remains package-private to restrict usage. ---- > Support asserting the contents of windows and panes in PAssert > -------------------------------------------------------------- > > Key: BEAM-155 > URL: https://issues.apache.org/jira/browse/BEAM-155 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Thomas Groh > > This consists of reifying the output windows and panes, and running asserts > per-window about the contents of panes. > This includes aggregated matching and final pane matching, e.g. > PAssert.that(output).byOnTimePane().hasOutputElements(foo, bar); > // For discarding mode - could have emitted (say) [spam, eggs], [spam], [], > [sausage], [] > PAssert.that(output).byFinalPane().hasOutputElements(spam, eggs, sausage, > spam); > // For accumulating mode without late data > PAssert.that(output).finalPane().containsInAnyOrder(spam, eggs, sausage, > spam); > // For accumulating mode with late data > PAssert.that(output).finalPane().containsInAnyOrder(foo, > bar).mayAlsoContain(baz, rab); > See also: > https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit# -- This message was sent by Atlassian JIRA (v6.3.4#6332)