[
https://issues.apache.org/jira/browse/BEAM-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242082#comment-15242082
]
ASF GitHub Bot commented on BEAM-155:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/180
[BEAM-155] Add AccumulateAllPanes PTransform
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This PTransform Reifies and accumulates all panes produced for each
window, outputting a single pane per window at the time the window is
Garbage Collected.
For use in PAssert, to match over the final contents of each window.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam accumulate_all_panes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
----
commit 5d4ae9e3ea131ac630de2381f0c2964c8a83b035
Author: Thomas Groh <tg...@google.com>
Date: 2016-03-31T00:07:53Z
Add AccumulateAllPanes PTransform
This PTransform Reifies and accumulates all panes produced for each
window, outputting a single pane per window at the time the window is
Garbage Collected.
For use in PAssert, to match over the final contents of each window.
----
> Support asserting the contents of windows and panes in PAssert
> --------------------------------------------------------------
>
> Key: BEAM-155
> URL: https://issues.apache.org/jira/browse/BEAM-155
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> This consists of reifying the output windows and panes, and running asserts
> per-window about the contents of panes.
> This includes aggregated matching and final pane matching, e.g.
> PAssert.that(output).byOnTimePane().hasOutputElements(foo, bar);
> // For discarding mode - could have emitted (say) [spam, eggs], [spam], [],
> [sausage], []
> PAssert.that(output).byFinalPane().hasOutputElements(spam, eggs, sausage,
> spam);
> // For accumulating mode without late data
> PAssert.that(output).finalPane().containsInAnyOrder(spam, eggs, sausage,
> spam);
> // For accumulating mode with late data
> PAssert.that(output).finalPane().containsInAnyOrder(foo,
> bar).mayAlsoContain(baz, rab);
> See also:
> https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
