Gujiawei-Edinburgh commented on code in PR #183:
URL: https://github.com/apache/bifromq/pull/183#discussion_r2434345418
##########
base-scheduler/src/main/java/org/apache/bifromq/basescheduler/Batcher.java:
##########
@@ -241,8 +245,8 @@ private IBatchCall<CallT, CallResultT, BatcherKeyT>
borrowBatchCall() {
return batchCall;
}
- private void returnBatchCall(IBatchCall<CallT, CallResultT, BatcherKeyT>
batchCall) {
- batchCall.reset();
+ private void returnBatchCall(IBatchCall<CallT, CallResultT, BatcherKeyT>
batchCall, boolean abort) {
+ batchCall.reset(abort);
Review Comment:
Are the abortions observable for end users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
