Gujiawei-Edinburgh commented on code in PR #183:
URL: https://github.com/apache/bifromq/pull/183#discussion_r2436083295
##########
bifromq-dist/bifromq-dist-worker/src/main/java/org/apache/bifromq/dist/worker/DistWorkerCoProc.java:
##########
@@ -472,26 +517,23 @@ private CompletableFuture<BatchDistReply>
batchDist(BatchDistRequest request) {
return
CompletableFuture.completedFuture(BatchDistReply.newBuilder().setReqId(request.getReqId()).build());
}
List<CompletableFuture<Void>> distFutures = new LinkedList<>();
- ConcurrentMap<String, TopicFanout.Builder> tenantTopicFanOuts = new
ConcurrentHashMap<>();
+ ConcurrentMap<String, Map<String, AtomicInteger>> tenantTopicFanOuts =
new ConcurrentHashMap<>();
Review Comment:
It looks like "tenantTopicFanOuts" is a local var, is it possiable to use
HashMap and Integer for fanout tracking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]