poorbarcode commented on PR #4140:
URL: https://github.com/apache/bookkeeper/pull/4140#issuecomment-1836922841
@merlimat I added an improvement for the ByteBuf typed `CompositeByteBuf`.
Could you review this PR again?
> I would assume we would have to run the test with JDK>=9 and pass a
buffer which is not purely direct memory or heap array based, eg. a
CompositeByteBuf with more than 1 segment.
Yes. Or run the test added with an option `--add-opens
java.base/java.util.zip=ALL-UNNAMED`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
