mattisonchao commented on code in PR #4140:
URL: https://github.com/apache/bookkeeper/pull/4140#discussion_r1412902881


##########
circe-checksum/src/main/java/com/scurrilous/circe/checksum/Java9IntHash.java:
##########
@@ -106,14 +107,22 @@ public int resume(int current, ByteBuf buffer, int 
offset, int len) {
         } else if (buffer.hasArray()) {
             int arrayOffset = buffer.arrayOffset() + offset;
             negCrc = resume(negCrc, buffer.array(), arrayOffset, len);
+        } else if (buffer instanceof CompositeByteBuf) {

Review Comment:
   Why not use separate PR to improve this one? :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to